Use Maven 4 as the runtime for m2eclipse #2053
Conversation
Test Results109 files - 215 109 suites - 215 18m 38s ⏱️ - 53m 18s For more details on these failures and errors, see this check. Results for commit 8aabf8e. ± Comparison against base commit 27eae6a. ♻️ This comment has been updated with latest results. |
HannesWell
force-pushed
the
maven4_runtime
branch
from
cda130d to
017a8bf
Compare
laeubi
force-pushed
the
maven4_runtime
branch
2 times, most recently
from
a954c36 to
a953a87
Compare
|
FYI @stbischof and @danthe1st as I know you are interested in Maven 4 support. This at least already compiles ... |
|
Whooop whooop!!!!! Thank you a lot for your work |
|
All tests are passing... except some of the flapping ones. So that's already promising, and as there is discussions about release Maven 4 soon (finally, really!) I think we then can quite easily upgrade here. So next logical step would be to create a Maven 4 testcase to see if maven features actually work! |
|
We get a lot of deprecation warnings now but that is expected and we should fix those later on. One thing we need to check is if the new runtime is actually used for run the tests! |
laeubi
force-pushed
the
maven4_runtime
branch
from
a953a87 to
dd28e85
Compare
laeubi
force-pushed
the
maven4_runtime
branch
from
6bbf4e7 to
430816a
Compare
|
It seems I was a bit to optimistic here, while the runtime itself compiles, due to we include the old ones as well these where picked up, if I enforce Maven 4 runtime the test fails (see previous commit) and if I enforce it to be used for compilation there are also compile error... so we need to check if
|
|
Wouldn't apache/maven#2380 supposed to help in this case? |
laeubi
force-pushed
the
maven4_runtime
branch
3 times, most recently
from
1d41df7 to
a177c2b
Compare
|
See also discussion here: |
Maven 4 will soon be released and should be able to execute Maven 3 projects as well. We should therefore upgrade m2e to use Maven 4 from now on. For users that require Maven 3.9 line we can offer the latest 3.9.11 maven runtime as an additional install option like we already did for Maven 3.9.6
laeubi
force-pushed
the
maven4_runtime
branch
3 times, most recently
from
25958be to
f6c3302
Compare
laeubi
force-pushed
the
maven4_runtime
branch
from
f6c3302 to
6b69674
Compare
| <target name="m2e-runtimes"> | ||
| <locations> | ||
| <location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="slicer" includeSource="false" type="InstallableUnit"> | ||
| <repository location="https://download.eclipse.org/technology/m2e/releases/2.2.1/"/> |
There was a problem hiding this comment.
The old link should continue to work as there should automated redirect to the archive.
| <includes | ||
| id="org.eclipse.m2e.feature.source" | ||
| version="0.0.0"/> | ||
|
|
There was a problem hiding this comment.
Can we move this to a separate PR?
|
@HannesWell this is currently only a draft so may contain some changes that must be cleaned up before a final version. I now have made it to compile again with Maven4 but possibly retain backwards compatible with Maven 3.9.x ... |
|
Maven has added some backward compatibility support now so with next release some of the things might no longer be needed, still we have some issues where we extend maven classes that now uses JSR330 in maven 4 with constructor injections. I need to check how we can overcome this. |
4 participants
Maven 4 will soon be released and should be able to execute Maven 3 projects as well. We should therefore upgrade m2e to use Maven 4 from now on.
For users that require Maven 3.9 line we can offer the latest 3.9.11 maven runtime as an additional install option like we already did for Maven 3.9.6